summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPablo Neira Ayuso2011-08-17 23:23:08 +0200
committerPablo Neira Ayuso2011-08-17 23:23:21 +0200
commita54269c81eda71611c05fae036f4eee78fb254f8 (patch)
tree4a2500ed45cf7eed141f8491d0f4920ea141dcc0
parente1_input: fix missing registration of dahdi driver (diff)
downloadlibosmo-abis-a54269c81eda71611c05fae036f4eee78fb254f8.tar.gz
libosmo-abis-a54269c81eda71611c05fae036f4eee78fb254f8.tar.xz
libosmo-abis-a54269c81eda71611c05fae036f4eee78fb254f8.zip
ipaccess: fix segfault if bsc port already in used
This patch fixes a segfault if we try to bind to an already busy port, it can be easily reproduced with: $ test/./e1inp_ipa_bsc_test & <0003> ipaccess.c:830 enabling ipaccess BSC mode <0000> e1inp_ipa_bsc_test.c:241 entering main loop $ test/./e1inp_ipa_bsc_test segfault
-rw-r--r--src/input/ipaccess.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index ef96bc4..836c2f8 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -840,7 +840,6 @@ static int ipaccess_line_update(struct e1inp_line *line,
if (ipa_server_link_open(oml_link) < 0) {
LOGP(DLINP, LOGL_ERROR, "cannot open OML BSC link: %s\n",
strerror(errno));
- ipa_server_link_close(oml_link);
ipa_server_link_destroy(oml_link);
return -EIO;
}
@@ -855,7 +854,6 @@ static int ipaccess_line_update(struct e1inp_line *line,
if (ipa_server_link_open(rsl_link) < 0) {
LOGP(DLINP, LOGL_ERROR, "cannot open RSL BSC link: %s\n",
strerror(errno));
- ipa_server_link_close(rsl_link);
ipa_server_link_destroy(rsl_link);
return -EIO;
}