summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJannik Schönartz2021-03-23 22:10:59 +0100
committerJannik Schönartz2021-03-23 22:10:59 +0100
commit639f2769730fed6ee0efac10f15b65086a26f8fa (patch)
treebe4dbf5e81e4122c6e6a034b711044f2d996ea7b
parent[server/registration] Show error msg and name input when infoblox has a fixed... (diff)
downloadbas-639f2769730fed6ee0efac10f15b65086a26f8fa.tar.gz
bas-639f2769730fed6ee0efac10f15b65086a26f8fa.tar.xz
bas-639f2769730fed6ee0efac10f15b65086a26f8fa.zip
[server/registration] Small bugfixes
-rw-r--r--server/api/registration.js2
-rw-r--r--server/lib/external-backends/backends/idoit-backend.js2
2 files changed, 2 insertions, 2 deletions
diff --git a/server/api/registration.js b/server/api/registration.js
index 09513c6..a556bbe 100644
--- a/server/api/registration.js
+++ b/server/api/registration.js
@@ -286,7 +286,7 @@ noAuthRouter.postAsync('/clients', async (req, res) => {
else if (!ipxe && ipCheck.leased && !ipCheck.error) return res.send({ client: client, ipList: ipCheck.nextIps })
// Set the hostname as clientname if it exists and is not a leased ip.
- if (!ipCheck.leased && ipCheck.name !== '') {
+ if (!ipCheck.leased && ipCheck.name) {
if (ipCheck.name) client.name = ipCheck.name
if (ipCheck.id) dhcp.ref = ipCheck.id
} else {
diff --git a/server/lib/external-backends/backends/idoit-backend.js b/server/lib/external-backends/backends/idoit-backend.js
index 6c30891..ddbab3e 100644
--- a/server/lib/external-backends/backends/idoit-backend.js
+++ b/server/lib/external-backends/backends/idoit-backend.js
@@ -131,7 +131,7 @@ class IdoitBackend extends ExternalBackends {
const failedDeletions = deleteRequest[0].result.message.match(errorRegex)
let result = []
- for (let failedObjId of failedDeletions) result.push({ error: true, message: `Deletion of object ${failedObjId} was skipped.`, id: failedObjId })
+ if (failedDeletions) for (let failedObjId of failedDeletions) result.push({ error: true, message: `Deletion of object ${failedObjId} was skipped.`, id: failedObjId })
return result
}