summaryrefslogtreecommitdiffstats
path: root/server/lib/external-backends
diff options
context:
space:
mode:
authorJannik Schönartz2019-03-15 15:59:52 +0100
committerJannik Schönartz2019-03-15 15:59:52 +0100
commit07639fbbc1440d8224365a5c0b0ae697989cd0fb (patch)
treeffd523301d993f462dbfdb7c89e84aebf0f65fff /server/lib/external-backends
parent[external-backeds] Big idoit rework, to match the updated api (diff)
downloadbas-07639fbbc1440d8224365a5c0b0ae697989cd0fb.tar.gz
bas-07639fbbc1440d8224365a5c0b0ae697989cd0fb.tar.xz
bas-07639fbbc1440d8224365a5c0b0ae697989cd0fb.zip
[server/registration] Add log to the first registration.
Diffstat (limited to 'server/lib/external-backends')
-rw-r--r--server/lib/external-backends/backendhelper.js4
-rw-r--r--server/lib/external-backends/backends/idoit-backend.js4
-rw-r--r--server/lib/external-backends/index.js12
3 files changed, 11 insertions, 9 deletions
diff --git a/server/lib/external-backends/backendhelper.js b/server/lib/external-backends/backendhelper.js
index bb95844..be41ebc 100644
--- a/server/lib/external-backends/backendhelper.js
+++ b/server/lib/external-backends/backendhelper.js
@@ -1,7 +1,8 @@
/* global __appdir */
const path = require('path')
const ExternalBackends = require(path.join(__appdir, 'lib', 'external-backends'))
-var db = require(path.join(__appdir, 'lib', 'sequelize'))
+const db = require(path.join(__appdir, 'lib', 'sequelize'))
+const log = require(path.join(__appdir, 'lib', 'log'))
module.exports = {
addClient: async function (client) {
@@ -41,6 +42,7 @@ module.exports = {
const clientDb = await db.client.findOne({ where: { id: client.id } })
backend.addMappedClients(clientDb, { through: { externalId: addClient.id, externalType: addClient.type } })
}
+ if (addClient.error && addClient.error !== 'NOT_IMPLEMENTED_EXCEPTION') log({ category: 'BACKEND_ERROR', description: `[${addClient.backendId}] ${addClient.error}: ${addClient.message}`, clientId: client.id })
result.push(addClient)
}
return result
diff --git a/server/lib/external-backends/backends/idoit-backend.js b/server/lib/external-backends/backends/idoit-backend.js
index 9325ad5..1fe7b5f 100644
--- a/server/lib/external-backends/backends/idoit-backend.js
+++ b/server/lib/external-backends/backends/idoit-backend.js
@@ -199,12 +199,12 @@ class IdoitBackend extends ExternalBackends {
// Send the create request.
const body = this.getBody('cmdb.object.create', params, 'client_create')
const requestCreate = await this.axiosRequest(c.url, [body], headers)
-
+ if (requestCreate.error) return { error: requestCreate.errno, message: 'Connection was refused.' }
// Purpose for Clients:
// 1 = Production | 5 = PVS
// 2 = Test | 7 = Pool PC
// 3 = Quality Assurance | 8 = Mitarbeiter Arbeitsplatz
- return { succes: true, id: requestCreate[0].result.id, type: params.type, message: requestCreate[0].result.message }
+ return { id: requestCreate[0].result.id, type: params.type, message: requestCreate[0].result.message }
}
/*
diff --git a/server/lib/external-backends/index.js b/server/lib/external-backends/index.js
index 755cef4..af7c2a1 100644
--- a/server/lib/external-backends/index.js
+++ b/server/lib/external-backends/index.js
@@ -110,7 +110,7 @@ class ExternalBackends {
* return: { success: <boolean>, status: '<STATUS_CODE_IF_ERROR>', error: '<ERROR_MESSAGE>' }
*/
async checkConnection (backend) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have a checkConnection method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have a checkConnection method' }
}
/* Returns an empty array [] if the backends doesn't have such a function.
@@ -132,7 +132,7 @@ class ExternalBackends {
* }
*/
async addClient (credentials, client) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an addClient method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an addClient method' }
}
/*
@@ -158,18 +158,18 @@ class ExternalBackends {
* }
*/
async updateClient (credentials, client) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an updateClient method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an updateClient method' }
}
async uploadFiles (credentials, externalId, files) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an uploadFiles method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an uploadFiles method' }
}
async getFileList (credentials, externalId) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an getFileList method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an getFileList method' }
}
async getFile (credentials, externalId, filename) {
- return { success: false, error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an getFile method' }
+ return { error: 'NOT_IMPLEMENTED_EXCEPTION', message: 'The provided backend does not have an getFile method' }
}
}